Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

two liner to make AlignmentTrackSelectorModule multi-threaded friendly #9906

Conversation

davidlange6
Copy link
Contributor

Picking up bug fix from Marco.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_7_4_X.

two liner to make AlignmentTrackSelectorModule multi-threaded friendly

It involves the following packages:

Alignment/CommonAlignmentProducer

@cmsbuild, @mmusich, @diguida, @cerminar can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @frmeier, @tlampen, @mschrode, @mmusich this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich
Copy link
Contributor

mmusich commented Jun 26, 2015

please test

@mmusich
Copy link
Contributor

mmusich commented Jun 26, 2015

@davidlange6 thanks. I was unable yesterday to test the PromptProd due to DAS issues.
Trying it again now, I will add commits here if needed.

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@mmusich
Copy link
Contributor

mmusich commented Jun 26, 2015

Added additional fixes in other selection modules affected.

@cmsbuild
Copy link
Contributor

-1
Tested at: f5d075b
When I ran the RelVals I found an error in the following worklfows:
25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15.log
----- Begin Fatal Exception 26-Jun-2015 10:37:34 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'validation_step'
   [2] Calling event method for module MixingModule/'mix'
Exception Message:
RootInputFileSequence::readOneSpecified(): no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9906/4/summary.html

@mmusich
Copy link
Contributor

mmusich commented Jun 26, 2015

The StripGains PCL workflow has been tested (successfully) through:

cmsDriver.py step1 --conditions auto:com10 -s RAW2DIGI,L1Reco,RECO,ALCAPRODUCER:@allForExpress+SiStripCalMinBias+SiStripPCLHistos,DQM,ENDJOB --process RECO --data --eventcontent ALCARECO,DQM --scenario pp --datatier ALCARECO,DQM --customise Configuration/DataProcessing/RecoTLR.customiseExpress -n 100 --dasquery="file dataset = /MinimumBias/Run2012D-v1/RAW run=208307" --fileout file:step1.root --no_exec
cmsRun step1_RAW2DIGI_L1Reco_RECO_ALCAPRODUCER_DQM_ENDJOB.py
cmsDriver.py step2 --datatier ALCARECO --conditions auto:com10 -s ALCA:PromptCalibProdSiStripGains --eventcontent ALCARECO -n 100 --filein file:step1.root --no_exec
cmsRun step2_ALCA.py
cmsDriver.py step3 --data --conditions auto:com10 --scenario pp -s ALCAHARVEST:SiStripGains --filein file:PromptCalibProdSiStripGains.root -n -1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@mmusich
Copy link
Contributor

mmusich commented Jun 26, 2015

Changes are also FWD ported to 7.5.X (in #9909) and in 7.6.X (in #9910)

@davidlange6
Copy link
Contributor Author

+1

cmsbuild added a commit that referenced this pull request Jun 26, 2015
…hreadedFriendly

two liner to make AlignmentTrackSelectorModule multi-threaded friendly
@cmsbuild cmsbuild merged commit 1ddf8ad into cms-sw:CMSSW_7_4_X Jun 26, 2015
@cmsbuild
Copy link
Contributor

cmsbuild added a commit that referenced this pull request Jun 26, 2015
…hreadedFriendly76X

Fix alignment track selector multi threaded friendly for 76X (fwdport of #9906)
cmsbuild added a commit that referenced this pull request Jun 26, 2015
…hreadedFriendly75X

Fix alignment track selector multi threaded friendly for 75X (fwdport of #9906)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants